Re: [PATCH] memcg: replace in_interrupt() by !in_task() in active_memcg()

[Shakeel Butt]

On Mon, Jul 26, 2021 at 9:53 AM Vasily Averin <vvs@xxxxxxxxxxxxx> wrote:
>
> set_active_memcg() uses in_interrupt() check to select proper storage for
> cgroup: pointer on task struct or per-cpu pointer.
>
> It isn't fully correct: obsoleted in_interrupt() includes tasks with disabled BH.
> It's better to use '!in_task()' instead.
>
> Link: https://lkml.org/lkml/2021/7/26/487
> Fixes: 37d5985c003d ("mm: kmem: prepare remote memcg charging infra for interrupt contexts")
> Signed-off-by: Vasily Averin <vvs@xxxxxxxxxxxxx>

Thanks.

Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>