Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types
From: Joerg Roedel
Date: Mon Jul 26 2021 - 08:46:51 EST
On Wed, Jul 21, 2021 at 07:20:27PM +0100, Robin Murphy wrote:
> - if (type == IOMMU_DOMAIN_DMA && using_legacy_binding)
> + if ((type & __IOMMU_DOMAIN_DMA_API) && using_legacy_binding)
Hmm, I wonder whether it is time to introduce helpers for these checks?
Something like iommu_domain_is_dma() is more readable.