Re: [PATCH v1 1/1] media: ipu3-cio2: Drop reference on error path in cio2_bridge_connect_sensor()

From: Andy Shevchenko
Date: Mon Jul 26 2021 - 08:04:27 EST


On Mon, Jul 26, 2021 at 3:01 PM Sakari Ailus
<sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> On Mon, Jul 26, 2021 at 02:55:51PM +0300, Andy Shevchenko wrote:
> > On Mon, Jul 26, 2021 at 2:47 PM Sakari Ailus
> > <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> > > On Mon, Jul 26, 2021 at 11:40:55AM +0300, Andy Shevchenko wrote:
> >
> > ...
> >
> > > > err_free_swnodes:
> > > > software_node_unregister_nodes(sensor->swnodes);
> > > > err_put_adev:
> > > > - acpi_dev_put(sensor->adev);
> > > > + acpi_dev_put(adev);
> > >
> > > adev is assigned to sensor->adev before goto so the two have the same
> > > value. I have no problem with the patch though.
> >
> > Are we reading the same version? Or am I missing something?
>
> I'm looking at the one in media-tree master.

Maintainers with a push access may FF merge the v5.14-rc3 as far as I
can tell and then you will see the difference.

--
With Best Regards,
Andy Shevchenko