Re: [PATCH V3 3/5] dt-bindings: gpio: Add bindings for gpio-virtio

From: Arnd Bergmann
Date: Mon Jul 26 2021 - 04:14:05 EST


On Mon, Jul 26, 2021 at 6:53 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> This patch adds binding for virtio GPIO controller, it is based on
> virtio-device bindings.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>, except

> +
> +properties:
> + $nodename:
> + pattern: '^gpio-virtio(-[a-z0-9]+)?$'
> +
> + gpio: gpio-virtio {
> + compatible = "virtio,29";

The node name here does not appear to be mandated by the schema, but
most others name it "gpio", so I would do the same here instead of
"gpio-virtio".

Arnd