Re: [PATCH v7] iomap: make inline data support more flexible

From: Matthew Wilcox
Date: Sun Jul 25 2021 - 23:08:02 EST


On Mon, Jul 26, 2021 at 12:16:39AM +0200, Andreas Gruenbacher wrote:
> @@ -247,7 +251,6 @@ iomap_readpage_actor(struct inode *inode, loff_t pos, loff_t length, void *data,
> sector_t sector;
>
> if (iomap->type == IOMAP_INLINE) {
> - WARN_ON_ONCE(pos);
> iomap_read_inline_data(inode, page, iomap);
> return PAGE_SIZE;

This surely needs to return -EIO if there was an error.