Re: [PATCH v1 1/1] serial: max310x: Use clock-names property matching to recognize XTAL

From: andriy.shevchenko@xxxxxxxxxxxxxxx
Date: Fri Jul 23 2021 - 08:29:03 EST


On Thu, Jul 22, 2021 at 09:05:13PM +0000, Dennis Giaya wrote:
> Andy,
>
> I've tested this out on my hardware that uses an external oscillator
> 'osc' (as opposed to external crystal 'xtal').
>
> With the relevant asl
> Package () {"compatible", "maxim,max14830"},
> Package ()
> {"clock-frequency", 19200000},
> Package () {"clock-names", "osc"},
>
> Previously, the driver logic would default to 'xtal' and then compare
> against the narrower frequency range and throw an error because 19.2MHz
> was not allowed. With your patch, it proceeds as 'osc' and appears to
> work as intended.

Thanks for testing!
I assume I may convert above to the Tested-by: or equivalent tag.

JFYI, in OSS mailing lists we do not top post.


--
With Best Regards,
Andy Shevchenko