Re: [PATCH v2 3/4] afs: Fix setting of writeback_index

[Marc Dionne]

On Mon, Jul 12, 2021 at 1:28 PM David Howells <dhowells@xxxxxxxxxx> wrote:
>
> Fix afs_writepages() to always set mapping->writeback_index to a page index
> and not a byte position[1].
>
> Fixes: 31143d5d515e ("AFS: implement basic file write support")
> Reported-by: Marc Dionne <marc.dionne@xxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@xxxxxxxxxxxxxx/ [1]
> cc: linux-afs@xxxxxxxxxxxxxxxxxxx
> ---
>
>  fs/afs/write.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/afs/write.c b/fs/afs/write.c
> index 1ed62e0ccfe5..c0534697268e 100644
> --- a/fs/afs/write.c
> +++ b/fs/afs/write.c
> @@ -784,7 +784,7 @@ int afs_writepages(struct address_space *mapping,
>         } else if (wbc->range_start == 0 && wbc->range_end == LLONG_MAX) {
>                 ret = afs_writepages_region(mapping, wbc, 0, LLONG_MAX, &next);
>                 if (wbc->nr_to_write > 0 && ret == 0)
> -                       mapping->writeback_index = next;
> +                       mapping->writeback_index = next / PAGE_SIZE;
>         } else {
>                 ret = afs_writepages_region(mapping, wbc,
>                                             wbc->range_start, wbc->range_end, &next);
>
>
>

Reviewed-by: Marc Dionne <marc.dionne@xxxxxxxxxxxx>

Marc