Re: [PATCH 07/20] perf test: maps__merge_in: fix memory leak of maps

From: Arnaldo Carvalho de Melo
Date: Thu Jul 15 2021 - 16:10:55 EST


Em Thu, Jul 15, 2021 at 06:07:12PM +0200, Riccardo Mancini escreveu:
> ASan reports a memory leak when running the perf test
> "65: maps__merge_in". This is the second and final patch addressing
> these memory leaks.
> This time, the problem is simply that the maps object is never
> destructed.
>
> This patch adds the missing maps__exit call.

Not really this one, but at least the patch should apply more easily:

Fixes: 79b6bb73f888933c ("perf maps: Merge 'struct maps' with 'struct map_groups'")

Thanks, applied.

- Arnaldo


> Signed-off-by: Riccardo Mancini <rickyman7@xxxxxxxxx>
> ---
> tools/perf/tests/maps.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/tests/maps.c b/tools/perf/tests/maps.c
> index edcbc70ff9d66e22..1ac72919fa358601 100644
> --- a/tools/perf/tests/maps.c
> +++ b/tools/perf/tests/maps.c
> @@ -116,5 +116,7 @@ int test__maps__merge_in(struct test *t __maybe_unused, int subtest __maybe_unus
>
> ret = check_maps(merged3, ARRAY_SIZE(merged3), &maps);
> TEST_ASSERT_VAL("merge check failed", !ret);
> +
> + maps__exit(&maps);
> return TEST_OK;
> }
> --
> 2.31.1
>

--

- Arnaldo