Re: [RFC PATCH 1/1] sched: do active load balance in balance callback

From: Dietmar Eggemann
Date: Wed Jul 14 2021 - 10:18:37 EST


On 14/07/2021 14:27, Valentin Schneider wrote:
> On 11/07/21 15:40, Yafang Shao wrote:
>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>> index 4ca80df205ce..a0a90a37e746 100644
>> --- a/kernel/sched/core.c
>> +++ b/kernel/sched/core.c
>> @@ -8208,6 +8208,7 @@ void __init sched_init(void)
>> rq->cpu_capacity = rq->cpu_capacity_orig = SCHED_CAPACITY_SCALE;
>> rq->balance_callback = &balance_push_callback;
>> rq->active_balance = 0;
>> + rq->active_balance_target = NULL;
>> rq->next_balance = jiffies;
>> rq->push_cpu = 0;
>> rq->cpu = i;
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 23663318fb81..9aaa75250cdc 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -7751,36 +7751,6 @@ static void detach_task(struct task_struct *p,
>> struct lb_env *env)
>
> Your mail client is breaking lines which pretty much wrecks the
> patch. Please use git send-email to submit patches, or look at
> Documentation/process/email-clients.rst to figure out how to tweak your
> client.

Yeah, wasn't able to apply this patch either.