Re: [PATCH v2] iio: accel: fxls8962af: fix potential use of uninitialized symbol

From: Jonathan Cameron
Date: Tue Jul 13 2021 - 13:45:55 EST


On Fri, 9 Jul 2021 09:17:27 +0200
Sean Nyekjaer <sean@xxxxxxxxxx> wrote:

> Fix this warning from kernel test robot:
> smatch warnings:
> drivers/iio/accel/fxls8962af-core.c:640
> fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
> Fixes: af959b7b96b8 ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")

Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan

> ---
> Changes since v2:
> - add commit msg
>
> drivers/iio/accel/fxls8962af-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index 078d87865fde..0019f1ea7df2 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data,
> return ret;
> }
>
> - return ret;
> + return 0;
> }
>
> static int fxls8962af_fifo_transfer(struct fxls8962af_data *data,