Re: [PATCH v3] kdb: Get rid of custom debug heap allocator

[Doug Anderson]

Hi,

On Tue, Jul 13, 2021 at 4:24 AM Sumit Garg <sumit.garg@xxxxxxxxxx> wrote:
>
> > >  int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab)
> > >  {
> > >         int ret = 0;
> > >         unsigned long symbolsize = 0;
> > >         unsigned long offset = 0;
> > > -#define knt1_size 128          /* must be >= kallsyms table size */
> > > -       char *knt1 = NULL;
> > > +       static char namebuf[KSYM_NAME_LEN];
> >
> > I guess this also ends up fixing a bug too, right? My greps show that
> > "KSYM_NAME_LEN" is 512
>
> I can see "KSYM_NAME_LEN" defined as 128 here [1]. Are you looking at
> any other header file?
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/kallsyms.h#n18

Ah ha, it's recent! See commit f2f6175186f4 ("kallsyms: increase
maximum kernel symbol length to 512")

...I guess this officially "Fixes" that commit then?

-Doug