Re: [PATCH v3 02/12] dt-bindings: phy: tegra20-usb-phy: Document properties needed for OTG mode

From: Dmitry Osipenko
Date: Mon Jul 12 2021 - 19:33:20 EST


12.07.2021 18:41, Rob Herring пишет:
>> + nvidia,pmc:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + Phandle to Power Management controller.
>> +
> Add a cell to this for the PHY reg offset and then get rid of the index:
>
>> + nvidia,phy-instance:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 2
>> + description: Unique hardware ID.

The instance ID belongs to the USB h/w and not to PMC. It may look like
I added the ID just to get offsets within PMC, but it's not like that.
The Tegra documentation explicitly assigns unique IDs to the USB
controllers and PHYs. Hence this ID should be the property of the PHY
hardware, IMO.