Re: [PATCH v2 4/7] net: phy: adin1100: Add ethtool get_stats support

[Jakub Kicinski]

On Mon, 12 Jul 2021 16:06:28 +0300 alexandru.tachici@xxxxxxxxxx wrote:
> +static const struct adin_hw_stat adin_hw_stats[] = {
> +	{ "total_frames_error_count",		0x8008 },
> +	{ "total_frames_count",			0x8009, 0x800A }, /* hi, lo */
> +	{ "length_error_frames_count",		0x800B },
> +	{ "alignment_error_frames_count",	0x800C },
> +	{ "symbol_error_count",			0x800D },
> +	{ "oversized_frames_count",		0x800E },
> +	{ "undersized_frames_count",		0x800F },
> +	{ "odd_nibble_frames_count",		0x8010 },
> +	{ "odd_preamble_packet_count",		0x8011 },
> +	{ "false_carrier_events_count",		0x8013 },
> +};

Since this phy seems to implement a lot MAC stats would it make sense
to plumb thru the new ethtool API for PHYs (ethtool_eth_mac_stats etc.)
rather than let the same string proliferation problem spring up in
another section of the code?