Re: [PATCH 1/3] crypto: qat - Simplify code and axe the use of a deprecated API
From: Andy Shevchenko
Date: Mon Jul 12 2021 - 06:21:10 EST
On Sun, Jul 11, 2021 at 08:13:18AM +0200, Christophe JAILLET wrote:
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> Replace 'pci_set_dma_mask/pci_set_consistent_dma_mask' by an equivalent
> and less verbose 'dma_set_mask_and_coherent()' call.
> If needed, see post from Christoph Hellwig on the kernel-janitors ML:
> https://marc.info/?l=kernel-janitors&m=158745678307186&w=4
See his another (recent) mail here: https://www.spinics.net/lists/kernel/msg3967232.html...
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
...and drop this part from all entries completely.
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> + if ((dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)))) {
--
With Best Regards,
Andy Shevchenko