Re: [PATCH] drivers:edac: Use DEVICE_ATTR helper macros

From: kernel test robot
Date: Sun Jul 11 2021 - 07:49:34 EST


Hi Dwaipayan,

I love your patch! Yet something to improve:

[auto build test ERROR on ras/edac-for-next]
[also build test ERROR on v5.13 next-20210709]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Dwaipayan-Ray/drivers-edac-Use-DEVICE_ATTR-helper-macros/20210711-152925
base: https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/adad6ecbf0efe710fee1495b85d840ad53825124
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dwaipayan-Ray/drivers-edac-Use-DEVICE_ATTR-helper-macros/20210711-152925
git checkout adad6ecbf0efe710fee1495b85d840ad53825124
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/edac/amd64_edac.c: In function 'dbam_show':
>> drivers/edac/amd64_edac.c:570:20: error: 'struct amd64_pvt' has no member named 'dbam'; did you mean 'dbam0'?
570 | EDAC_DCT_ATTR_SHOW(dbam);
| ^~~~
drivers/edac/amd64_edac.c:566:48: note: in definition of macro 'EDAC_DCT_ATTR_SHOW'
566 | return sprintf(data, "0x%016llx\n", (u64)pvt->reg); \
| ^~~
drivers/edac/amd64_edac.c: In function 'topmem_show':
>> drivers/edac/amd64_edac.c:571:20: error: 'struct amd64_pvt' has no member named 'topmem'; did you mean 'top_mem'?
571 | EDAC_DCT_ATTR_SHOW(topmem);
| ^~~~~~
drivers/edac/amd64_edac.c:566:48: note: in definition of macro 'EDAC_DCT_ATTR_SHOW'
566 | return sprintf(data, "0x%016llx\n", (u64)pvt->reg); \
| ^~~
drivers/edac/amd64_edac.c: In function 'topmem2_show':
>> drivers/edac/amd64_edac.c:572:20: error: 'struct amd64_pvt' has no member named 'topmem2'; did you mean 'top_mem2'?
572 | EDAC_DCT_ATTR_SHOW(topmem2);
| ^~~~~~~
drivers/edac/amd64_edac.c:566:48: note: in definition of macro 'EDAC_DCT_ATTR_SHOW'
566 | return sprintf(data, "0x%016llx\n", (u64)pvt->reg); \
| ^~~
drivers/edac/amd64_edac.c:567:1: error: control reaches end of non-void function [-Werror=return-type]
567 | }
| ^
drivers/edac/amd64_edac.c:572:1: note: in expansion of macro 'EDAC_DCT_ATTR_SHOW'
572 | EDAC_DCT_ATTR_SHOW(topmem2);
| ^~~~~~~~~~~~~~~~~~
drivers/edac/amd64_edac.c: In function 'topmem_show':
drivers/edac/amd64_edac.c:567:1: error: control reaches end of non-void function [-Werror=return-type]
567 | }
| ^
drivers/edac/amd64_edac.c:571:1: note: in expansion of macro 'EDAC_DCT_ATTR_SHOW'
571 | EDAC_DCT_ATTR_SHOW(topmem);
| ^~~~~~~~~~~~~~~~~~
drivers/edac/amd64_edac.c: In function 'dbam_show':
drivers/edac/amd64_edac.c:567:1: error: control reaches end of non-void function [-Werror=return-type]
567 | }
| ^
drivers/edac/amd64_edac.c:570:1: note: in expansion of macro 'EDAC_DCT_ATTR_SHOW'
570 | EDAC_DCT_ATTR_SHOW(dbam);
| ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors


vim +570 drivers/edac/amd64_edac.c

568
569 EDAC_DCT_ATTR_SHOW(dhar);
> 570 EDAC_DCT_ATTR_SHOW(dbam);
> 571 EDAC_DCT_ATTR_SHOW(topmem);
> 572 EDAC_DCT_ATTR_SHOW(topmem2);
573

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip