Re: [PATCH AUTOSEL 5.10 46/93] char: xillybus: Fix condition for invoking the xillybus/ subdirectory

From: Eli Billauer
Date: Sat Jul 10 2021 - 01:19:10 EST


Hello Sasha,

Thanks for trying, but this is a NACK.

On 10/07/21 05:23, Sasha Levin wrote:
diff --git a/drivers/char/Makefile b/drivers/char/Makefile
index ffce287ef415..c7e4fc733a37 100644
--- a/drivers/char/Makefile
+++ b/drivers/char/Makefile
@@ -44,6 +44,6 @@ obj-$(CONFIG_TCG_TPM) += tpm/

obj-$(CONFIG_PS3_FLASH) += ps3flash.o

-obj-$(CONFIG_XILLYBUS) += xillybus/
+obj-$(CONFIG_XILLYBUS_CLASS) += xillybus/
obj-$(CONFIG_POWERNV_OP_PANEL) += powernv-op-panel.o

CONFIG_XILLYBUS_CLASS will be introduced in v5.14, so backporting this commit will break the kernel's build.

Since this patch was created for three kernel versions, I'm repeating this response on all three, just be sure. Hope I'm not being annoying.

Eli