RE: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API support

[Nava kishore Manne]

Hi Greg,

	Thanks for providing the review comments.
Please find my response inline.

> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Wednesday, June 9, 2021 3:25 PM
> To: Nava kishore Manne <navam@xxxxxxxxxx>
> Cc: robh+dt@xxxxxxxxxx; Michal Simek <michals@xxxxxxxxxx>;
> mdf@xxxxxxxxxx; trix@xxxxxxxxxx; arnd@xxxxxxxx; Rajan Vaja
> <RAJANV@xxxxxxxxxx>; Amit Sunil Dhamne <amitsuni@xxxxxxxxxxxxxxx>;
> Tejas Patel <tejasp@xxxxxxxxxxxxxxx>; zou_wei@xxxxxxxxxx; Sai Krishna
> Potthuri <lakshmis@xxxxxxxxxx>; Ravi Patel <RAVIPATE@xxxxxxxxxx>;
> iwamatsu@xxxxxxxxxxx; Jiaying Liang <jliang@xxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-fpga@xxxxxxxxxxxxxxx; git <git@xxxxxxxxxx>;
> chinnikishore369@xxxxxxxxx
> Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API
> support
> 
> On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote:
> > This patch adds user encrypted key load API to support User key
> > encrypted images loading use cases from Linux.
> 
> What is "user key encrypted images"?  Do we need more documentation
> here for what this is and how to use it?
> 

Xilinx bitstream writer, using AES, encrypts the bitstream. This feature allows user to encrypt bitstream using 256-bit AES encryption in cipher block chaining (CBC) mode.
User can supply a 128-bit Initial Vector and 256-bit key(user key).
For more info please refer here: 
https://www.xilinx.com/support/documentation/application_notes/xapp1239-fpga-bitstream-encryption.pdf 

> And why is "User" capitalized?
> 

Will fix.

Regards,
Navakishore.