Re: [PATCH 1/6] KVM: nSVM: Check the value written to MSR_VM_HSAVE_PA

From: Maxim Levitsky
Date: Fri Jul 09 2021 - 02:09:01 EST


On Thu, 2021-07-08 at 19:27 +0200, Paolo Bonzini wrote:
> On 07/07/21 12:28, Maxim Levitsky wrote:
> > Minor nitpick: I would have checked the host provided value as well,
> > just in case since there is no reason why it won't pass the same check,
> > and fail if the value is not aligned.
>
> The reason not to do so is that it would allow a guest running an old
> kernel to defeat live migration.
I understand now, and I will keep this in mind next time.

Best regards,
Maxim Levitsky

>
> Paolo
>
> > Other than that:
> > Reviewed-by: Maxim Levitsky<mlevitsk@xxxxxxxxxx>