Re: [PATCH v1, 04/14] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings

From: Tzung-Bi Shih
Date: Thu Jul 08 2021 - 06:05:10 EST


On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong <yunfei.dong@xxxxxxxxxxxx> wrote:
> .../media/mediatek-vcodec-decoder.txt | 169 ++++++++++++++++++
> .../media/mediatek-vcodec-encoder.txt | 73 ++++++++
> 2 files changed, 242 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-decoder.txt
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-encoder.txt
The patch is weird. Its title says "separate" but the changes are all
creating new content.

Would expect the patch to remove content from some files (e.g.
Documentation/devicetree/bindings/media/mediatek-vcodec.txt) and
separate into 2 files.

Also would expect the patch is a refactor which shouldn't introduce
any new things.