Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module

From: Krzysztof Kozlowski
Date: Mon Jul 05 2021 - 11:15:08 EST


On 14/05/2021 16:04, Krzysztof Kozlowski wrote:
> On 14/05/2021 09:48, Guenter Roeck wrote:
>> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
>>> When rt2880_wdt watchdog driver is built as a module, the
>>> rt_sysc_membase needs to be exported (it is being used via inlined
>>> rt_sysc_r32):
>>>
>>> ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
>>>
>>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>>
>> Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>>
>> I don't see a recent change in the code. Has that problem been there
>> all along ?
>
> I think the problem was there always but 0-day builder did not hit it
> until recently:
> https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@xxxxxxxxx/

Hi Guenter,

It seems that patch was not applied. Anything to fix here?


Best regards,
Krzysztof