Re: [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids

[Michael Walle]

Hi Hongwei,

Am 2021-06-30 20:20, schrieb Hongwei Zhang:
> > Am 2021-06-29 17:08, schrieb Hongwei Zhang:
> > > Add some Micron M45PEx flash memeories into the IDs table.
> >
> > Did you test all these flashes?
> No, the patch was added in porting drivers related to AST2600 EVB.

Please note, that all flashes which are added must be tested.

> > > Fixes: dd1e9367157f900616f (ARM: dts: everest: Add phase corrections
> > > for
> > > eMMC)
> >
> > Bogus Fixes tag. First, I cannot find this commit id, which tree is
> > that? Secondly, adding new flash ids don't fix anything, esp not
> > something related to eMMC.
> Sorry for the confusion, I thought Fixes tag could be also used for 
> referencing
> the revision base for the patch to aplly on.
> I used dev-5.10 branch from https://github.com/openbmc/linux.git , 
> should I
> use a different repository?

AFAIK commits in fixes tags must be relative to Linus Torvalds' tree
(or a subtree must not rebase, like the networking trees, which means
they will end up in Torvalds' tree).

Anyway, this is not a fix and therefore there must be no Fixes: tag.

-michael