Re: [patch V3 28/66] x86/fpu: Rename copy_user_to_xregs() and copy_xregs_to_user()

From: Borislav Petkov
Date: Mon Jun 21 2021 - 15:44:31 EST


On Fri, Jun 18, 2021 at 04:18:51PM +0200, Thomas Gleixner wrote:
> The function names for xsave[s]/xrstor[s] operations are horribly named and
> a permanent source of confusion.
>
> Rename:
> copy_xregs_to_user() to xsave_to_user_sigframe()
> copy_user_to_xregs() to xrstor_from_user_sigframe()
>
> so it's entirely clear what this is about. This is also a clear indicator
> of the potentially different storage format because this is user ABI and
> cannot use compacted format.
>
> No functional change.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> arch/x86/include/asm/fpu/internal.h | 4 ++--
> arch/x86/kernel/fpu/signal.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg