Re: [PATCH -next 2/4] ASoC: samsung: pcm: Use devm_platform_get_and_ioremap_resource()

From: Krzysztof Kozlowski
Date: Mon Jun 21 2021 - 05:22:57 EST


On 16/06/2021 11:16, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> sound/soc/samsung/pcm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
> index bfd76e9cc0ca..4c4dfde0568f 100644
> --- a/sound/soc/samsung/pcm.c
> +++ b/sound/soc/samsung/pcm.c
> @@ -512,8 +512,7 @@ static int s3c_pcm_dev_probe(struct platform_device *pdev)
> /* Default is 128fs */
> pcm->sclk_per_fs = 128;
>
> - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - pcm->regs = devm_ioremap_resource(&pdev->dev, mem_res);
> + pcm->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &mem_res);
> if (IS_ERR(pcm->regs))
> return PTR_ERR(pcm->regs);
>
>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>

Best regards,
Krzysztof