Re: [PATCH v6 1/2] x86/sev: Make sure IRQs are disabled while GHCB is active

From: Joerg Roedel
Date: Fri Jun 18 2021 - 04:25:19 EST


On Thu, Jun 17, 2021 at 05:00:48PM +0200, Peter Zijlstra wrote:
> I think this is broken, at this point RCU is quite dead on this CPU and
> local_irq_save/restore include tracing and all sorts.
>
> Also, shouldn't IRQs already be disabled by the time we get here?

Yes it is, I removed these calls, made __sev_get/put_ghcb() noinstr
instead of __always_inline and put instrumentation_begin()/end() around
the panic() call in __sev_get_ghcb().

Regards,

Joerg