[PATCH 1/2] bus: mhi: Fix pm_state conversion to string

From: Paul Davey
Date: Thu Jun 17 2021 - 23:32:38 EST


On big endian architectures the mhi debugfs files which report pm state
give "Invalid State" for all states.

Fix to_mhi_pm_state_str by using a local unsigned long as an intemediate
to pass the state to find_last_bit to avoid endianness issues with cast
from enum mhi_pm_state * to unsigned long *.

Signed-off-by: Paul Davey <paul.davey@xxxxxxxxxxxxxxxxxxx>
---
drivers/bus/mhi/core/init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index c81b377fca8f..87cc0c449078 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -79,7 +79,8 @@ static const char * const mhi_pm_state_str[] = {

const char *to_mhi_pm_state_str(enum mhi_pm_state state)
{
- int index = find_last_bit((unsigned long *)&state, 32);
+ unsigned long tmp = state;
+ int index = find_last_bit((unsigned long *)&tmp, 32);

if (index >= ARRAY_SIZE(mhi_pm_state_str))
return "Invalid State";
--
2.32.0