Re: [PATCH] serial: amba-pl011: add RS485 support

From: Lino Sanfilippo
Date: Thu Jun 17 2021 - 13:44:33 EST



Hi,

On 16.06.21 at 08:18, Jiri Slaby wrote:
        mdelay(port->rs485.delay_rts_before_send);
>
> This is up to 1 second delay with interrupts disabled. Definitely not nice. 8250 clamps this to 100 ms at least, why did you choose 1000 ms?
>

AFAICS the 8250 driver does not clamp values read from the device tree property "rs485-rts-delay"
(set by uart_get_rs485_mode()). Is this on purpose?

Regards,
Lino