Re: [PATCH] perf/x86/rapl: Use CPUID bit on AMD and Hygon parts

From: Borislav Petkov
Date: Mon May 31 2021 - 13:19:06 EST


On Fri, May 14, 2021 at 02:59:20PM +0100, Andrew Cooper wrote:
> diff --git a/arch/x86/kernel/cpu/powerflags.c b/arch/x86/kernel/cpu/powerflags.c
> index fd6ec2aa0303..e2055f51342e 100644
> --- a/arch/x86/kernel/cpu/powerflags.c
> +++ b/arch/x86/kernel/cpu/powerflags.c
> @@ -21,4 +21,6 @@ const char *const x86_power_flags[32] = {
> "eff_freq_ro", /* Readonly aperf/mperf */
> "proc_feedback", /* processor feedback interface */
> "acc_power", /* accumulated power mechanism */
> + "conn_standby", /* Connected Standby */
> + "rapl", /* Runtime Average Power Limit */

Yeah, so this repeats the "rapl" bit and that "conn_standby" is probably
not gonna be used. Unless you have a really good reason to add that
hunk, I'll whack it before applying and let this "power management"
thing in /proc/cpuinfo die unchanged.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette