Re: [PATCH 2/2] usb: typec: mux: Remove requirement for the "orientation-switch" device property

From: Heikki Krogerus
Date: Mon May 31 2021 - 08:34:01 EST


> > > Oh no. This patch just landed into Greg's usb-next. I'll prepare the
> > > revert. I'm sorry about this.
> >
> > Actually, if we always need that extra (boolean) device property to identify
> > the device class when OF graph is used,
>
> Looks like yes, as we need a way to know if the current fwnode
> is for the target device we are looking for, to return probe
> defer correctly.
>
> > shouldn't we just do that always
> > in fwnode_graph_devcon_match()?
>
> This depends on if we want to limit this to be a boolean property
> (to mark this is the target fwnode), or make it to be more generic
> so user can define it in its ->match().
>
> Now there are only 2 users of it, role switch and typec mux, both work
> as a boolean property for con_id.


OK. Let's leave to the users for now.

thanks,

--
heikki