Re: [PATCH v2 0/3] staging: iio: cdc: ad7746: initial effort to move out of staging

[Lucas Stankus]

On Wed, May 26, 2021 at 2:05 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> On Sun, 23 May 2021 14:11:35 -0300
> Lucas Stankus <lucas.p.stankus@xxxxxxxxx> wrote:
>
> > Tidy up driver code by removing vague comments, simplifying probe
> > return, and extracting capdac register write to a separate function.
> >
> > These small patches are a starting point for improving the ad7746 driver,
> > hopefully to a point where it's possible to get it out of staging. I'm
> > looking up to feedback on what could be improved to accomplish that.
> Usually the easiest way to get such feedback is to propose moving it out of
> staging, (with move detection turned off in git format-patch).
> Then we'll review it in a similar fashion to a new driver.

Oh okay, sorry for the unconventional patch set then and thanks for
giving me the heads up about the format-patch flag, I'd probably get
that wrong if you didn't =/

>
> Starting point though for any review is ABI.  Looks like there is some
> custom stuff in here which either needs to go away or be properly
> proposed and documented.

Nice, I'll look into that.


>
> This series applied to the togreg branch of iio.git - initially
> pushed out as testing to let 0-day poke at it.
>
> Thanks,
>
> Jonathan
>
> >
> > changelog v1 -> v2:
> > - Dropped num_channels fixup patch (applied from previous series).
> > - Split general code style patch into several atomic ones.
> > - New patch to catch capdac write boilerplate into a single function.
> >
> > Lucas Stankus (3):
> >   staging: iio: cdc: ad7746: remove ordinary comments
> >   staging: iio: cdc: ad7746: clean up probe return
> >   staging: iio: cdc: ad7746: extract capac setup to own function
> >
> >  drivers/staging/iio/cdc/ad7746.c | 58 +++++++++++++-------------------
> >  1 file changed, 23 insertions(+), 35 deletions(-)
> >
>