Re: [PATCH 10/15] openrisc: convert to setup_initial_init_mm()

From: Stafford Horne
Date: Sat May 29 2021 - 09:48:56 EST


On Sat, May 29, 2021 at 06:54:59PM +0800, Kefeng Wang wrote:
> Use setup_initial_init_mm() helper to simplify code.
>
> Cc: Jonas Bonn <jonas@xxxxxxxxxxxx>
> Cc: Stefan Kristiansson <stefan.kristiansson@xxxxxxxxxxxxx>
> Cc: Stafford Horne <shorne@xxxxxxxxx>
> Cc: openrisc@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>

Looks fine to me.

Acked-by: Stafford Horne <shorne@xxxxxxxxx>

> ---
> arch/openrisc/kernel/setup.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
> index c6f9e7b9f7cb..8ae2da6ac097 100644
> --- a/arch/openrisc/kernel/setup.c
> +++ b/arch/openrisc/kernel/setup.c
> @@ -293,10 +293,7 @@ void __init setup_arch(char **cmdline_p)
> #endif
>
> /* process 1's initial memory region is the kernel code/data */
> - init_mm.start_code = (unsigned long)_stext;
> - init_mm.end_code = (unsigned long)_etext;
> - init_mm.end_data = (unsigned long)_edata;
> - init_mm.brk = (unsigned long)_end;
> + setup_initial_init_mm(_stext, _etext, _edata, _end);
>
> #ifdef CONFIG_BLK_DEV_INITRD
> if (initrd_start == initrd_end) {
> --
> 2.26.2
>