Re: [PATCH v10 32/33] fs/netfs: Add folio fscache functions

From: Christoph Hellwig
Date: Thu May 27 2021 - 04:24:16 EST


On Tue, May 11, 2021 at 10:47:34PM +0100, Matthew Wilcox (Oracle) wrote:
> Match the page writeback functions by adding
> folio_start_fscache(), folio_end_fscache(), folio_wait_fscache() and
> folio_wait_fscache_killable(). Also rewrite the kernel-doc to describe
> when to use the function rather than what the function does, and include
> the kernel-doc in the appropriate rst file.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Looks fine, but doesn't actually seem to be needed for this series.
I'd move it closer to actual users of the new helpers.

Otherwise:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>