Re: [PATCH v1 1/4] dt-bindings: aspeed-sgpio: Convert txt bindings to yaml.

From: Steven Lee
Date: Wed May 26 2021 - 21:03:19 EST


The 05/27/2021 08:57, Andrew Jeffery wrote:
> Hi Steven,
>
> On Wed, 26 May 2021, at 19:16, Steven Lee wrote:
> > SGPIO bindings should be converted as yaml format.
> > In addition to the file conversion, a new property max-ngpios is
> > added in the yaml file as well.
> > The new property is required by the enhanced sgpio driver for
> > making the configuration of the max number of gpio pins more flexible.
>
> Please add the new property in a separate patch to the YAML conversion.
> Having changes to the properties in addition to switching to dt schema
> makes it harder to catch errors, and it seems Rob's bot has already
> picked up some.
>
> Reviewing the changes as separate patches means its easier to give you
> a Reviewed-by tag on that patches I'm happy with.
>

Thanks for your suggestion, I will add the new property in a
separate patch in v3 patch series.

> Andrew