Re: [PATCH] m68k: Drop duplicate "core-y += arch/m68k/" rule causing link failures

From: Geert Uytterhoeven
Date: Wed May 26 2021 - 10:51:51 EST


Hi Yamada-san,

On Wed, May 26, 2021 at 4:24 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> On Wed, May 26, 2021 at 5:45 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > Makefile:1949: target 'arch/m68k' given more than once in the same rule
> > [...]
> > LD vmlinux.o
> > m68k-linux-gnu-ld: arch/m68k/kernel/entry.o: in function `system_call':
> > (.text+0x160): multiple definition of `system_call'; arch/m68k/kernel/entry.o:(.text+0x160): first defined here
> > [...]
> >
> > All "core-y += arch/<arch>/" rules were dropped from the corresponding
> > arch/<arch>/Makefiles, but m68k was forgotten.
> >
> > Reported-by: noreply@xxxxxxxxxxxxxx
> > Fixes: 7d9677835b10b5de ("kbuild: require all architectures to have arch/$(SRCARCH)/Kbuild")
> > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > ---
>
> I will squash this.

Fine for me. Thx!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds