Re: [PATCH v2 0/3] EM / PM: Inefficient OPPs

From: Viresh Kumar
Date: Wed May 26 2021 - 05:39:28 EST


On 26-05-21, 15:08, Viresh Kumar wrote:
> On 26-05-21, 10:01, Vincent Donnefort wrote:
> > I originally considered to add the inefficient knowledge into the CPUFreq table.
>
> I wasn't talking about the cpufreq table here in the beginning, but calling
> dev_pm_opp_disable(), which will eventually reflect in cpufreq table as well.
>
> > But I then gave up the idea for two reasons:
> >
> > * The EM depends on having schedutil enabled. I don't think that any
> > other governor would then manage to rely on the inefficient OPPs. (also I
> > believe Peter had a plan to keep schedutil as the one and only governor)
>
> Right, that EM is only there for schedutil.
>
> I would encourage if this can be done even without the EM dependency, if
> possible. It would be a good thing to do generally for any driver that wants to
> do that.

Another benefit of course is that we will have less work to do in the hotpath,
it was obvious, but I thought of stating it anyway :)

--
viresh