Re: [PATCH 2/3] x86/syscalls: Remove -Wno-override-init for syscall tables

From: Masahiro Yamada
Date: Tue May 25 2021 - 08:02:39 EST


On Tue, May 25, 2021 at 3:17 AM Brian Gerst <brgerst@xxxxxxxxx> wrote:
>
> Commit 44fe4895f47c ("Stop filling syscall arrays with *_sys_ni_syscall")
> removes the need for -Wno-override-init, since the table is now filled
> sequentially instead of overriding a default value.
>
> Signed-off-by: Brian Gerst <brgerst@xxxxxxxxx>
> ---


Reviewed-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>


> arch/x86/entry/Makefile | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile
> index 08bf95dbc911..94d2843ce80c 100644
> --- a/arch/x86/entry/Makefile
> +++ b/arch/x86/entry/Makefile
> @@ -17,10 +17,6 @@ CFLAGS_syscall_64.o += -fno-stack-protector
> CFLAGS_syscall_32.o += -fno-stack-protector
> CFLAGS_syscall_x32.o += -fno-stack-protector
>
> -CFLAGS_syscall_64.o += $(call cc-option,-Wno-override-init,)
> -CFLAGS_syscall_32.o += $(call cc-option,-Wno-override-init,)
> -CFLAGS_syscall_x32.o += $(call cc-option,-Wno-override-init,)
> -
> obj-y := entry_$(BITS).o thunk_$(BITS).o syscall_$(BITS).o
> obj-y += common.o
>
> --
> 2.31.1
>


--
Best Regards
Masahiro Yamada