Re: [PATCH 0/6] Don't use BIT() macro in UAPI headers

From: Christoph Hellwig
Date: Mon May 24 2021 - 07:47:39 EST


On Thu, May 20, 2021 at 03:43:37AM -0700, Joe Richey wrote:
> This patch series changes all UAPI uses of BIT() to just be open-coded.
> However, there really should be a check for this in checkpatch.pl
> Currently, the script actually _encourages_ users to use the BIT macro
> even if adding things to UAPI.

Yes. In fact it should warn about BIT() in general. It is totally
pointless obsfucation that doesn't even save any typing at all.