Re: [PATCH v2] clocksource/drivers/hyper-v: Re-enable VDSO_CLOCKMODE_HVCLOCK on X86

[Wei Liu]

On Sat, May 15, 2021 at 09:06:37PM +0200, Thomas Gleixner wrote:
> On Sat, May 15 2021 at 15:43, Wei Liu wrote:
> 
> > On Thu, May 13, 2021 at 01:29:12PM +0000, Michael Kelley wrote:
> >> From: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> Sent: Thursday, May 13, 2021 12:33 AM
> >> > 
> >> > Mohammed reports (https://bugzilla.kernel.org/show_bug.cgi?id=213029)
> >> > the commit e4ab4658f1cf ("clocksource/drivers/hyper-v: Handle vDSO
> >> > differences inline") broke vDSO on x86. The problem appears to be that
> >> > VDSO_CLOCKMODE_HVCLOCK is an enum value in 'enum vdso_clock_mode' and
> >> > '#ifdef VDSO_CLOCKMODE_HVCLOCK' branch evaluates to false (it is not
> >> > a define). Use a dedicated HAVE_VDSO_CLOCKMODE_HVCLOCK define instead.
> >> > 
> >> > Suggested-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> >> > Reported-by: Mohammed Gamal <mgamal@xxxxxxxxxx>
> >> > Fixes: e4ab4658f1cf ("clocksource/drivers/hyper-v: Handle vDSO differences inline")
> >> > Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> > [...]
> >> 
> >> Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> >> 
> > Applied to hyperv-fixes. Thanks.
> 
> It's already in the tip tree...

Okay. I will drop it. Thanks.