Re: hwmon: (pcf8591) Unused attribute group pcf8591_attr_group_opt

From: Guenter Roeck
Date: Sat May 15 2021 - 09:44:52 EST


On 5/15/21 6:20 AM, Evgeny Novikov wrote:
Driver drivers/hwmon/pcf8591.ko declares and removes attribute group
pcf8591_attr_group_opt, but it does not create it ever. Is it better to remove
it completely or to do something else?

Do nothing. Look closely at the file instead to see how the attributes
are created, and realize that the group is only used to simplify
attribute removal.

Yes, the code is a bit odd and unusual, but it is WAI.

Guenter