Re: [PATCH 5.10 380/530] udp: never accept GSO_FRAGLIST packets

From: Pavel Machek
Date: Sat May 15 2021 - 04:37:39 EST


Hi!

> From: Paolo Abeni <pabeni@xxxxxxxxxx>
>
> [ Upstream commit 78352f73dc5047f3f744764cc45912498c52f3c9 ]
>
> Currently the UDP protocol delivers GSO_FRAGLIST packets to
> the sockets without the expected segmentation.
>
> This change addresses the issue introducing and maintaining
> a couple of new fields to explicitly accept SKB_GSO_UDP_L4
> or GSO_FRAGLIST packets. Additionally updates udp_unexpected_gso()
> accordingly.
>
> UDP sockets enabling UDP_GRO stil keep accept_udp_fraglist
> zeroed.

What is going on here? accept_udp_fraglist variable is read-only.

Should this be dropped? Should

commit d18931a92a0b5feddd8a39d097b90ae2867db02f
vxlan: allow L4 GRO passthrough

be cherry-picked?

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: Digital signature