Re: [PATCH] kcsan: fix debugfs initcall return type

From: Arnd Bergmann
Date: Fri May 14 2021 - 17:17:10 EST


On Fri, May 14, 2021 at 10:18 PM Paul E. McKenney <paulmck@xxxxxxxxxx> wrote:
> On Fri, May 14, 2021 at 01:11:05PM -0700, Nathan Chancellor wrote:

> > You can see my response to Marco here:
> >
> > https://lore.kernel.org/r/ad7fa126-f371-5a24-1d80-27fe8f655b05@xxxxxxxxxx/
> >
> > Maybe some improved wording might look like
> >
> > clang with CONFIG_LTO_CLANG points out that an initcall function should
> > return an 'int' due to the changes made to the initcall macros in commit
> > 3578ad11f3fb ("init: lto: fix PREL32 relocations"):
>
> OK, so the naive reading was correct, thank you!
>
> > ...
> >
> > Arnd, do you have any objections?
>
> In the meantime, here is what I have. Please let me know of any needed
> updates.
>

Looks good to me, thanks for the improvements!

Arnd