Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module

From: John Crispin
Date: Fri May 14 2021 - 14:32:02 EST



On 14.05.21 15:48, Guenter Roeck wrote:
On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
When rt2880_wdt watchdog driver is built as a module, the
rt_sysc_membase needs to be exported (it is being used via inlined
rt_sysc_r32):

   ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

I don't see a recent change in the code. Has that problem been there
all along ?


yes it has ...

Acked-by: John Crispin <john@xxxxxxxxxxx>