Re: [PATCH AUTOSEL 5.12 090/116] ASoC: rt286: Generalize support for ALC3263 codec

From: Sasha Levin
Date: Fri May 14 2021 - 09:04:31 EST


On Fri, May 07, 2021 at 12:34:29AM -0400, David Ward wrote:
On 5/5/21 12:30 PM, Sasha Levin wrote:
From: David Ward <david.ward@xxxxxxxxxx>

[ Upstream commit aa2f9c12821e6a4ba1df4fb34a3dbc6a2a1ee7fe ]

The ALC3263 codec on the XPS 13 9343 is also found on the Latitude 13 7350
and Venue 11 Pro 7140. They require the same handling for the combo jack to
work with a headset: GPIO pin 6 must be set.

The HDA driver always sets this pin on the ALC3263, which it distinguishes
by the codec vendor/device ID 0x10ec0288 and PCI subsystem vendor ID 0x1028
(Dell). The ASoC driver does not use PCI, so adapt this check to use DMI to
determine if Dell is the system vendor.

For this patch to be useful, commit cd8499d5c03b ("ASoC: rt286: Make RT286_SET_GPIO_* readable and writable") from the same series is needed as well, which fixed the regmap config.

(The same comment is true for all stable branches.)

I'll take it too, thanks!

--
Thanks,
Sasha