Re: [PATCH v3 13/18] crypto: rsa-psspad: Get signature parameters from a given signature

From: Herbert Xu
Date: Fri May 14 2021 - 06:46:23 EST


On Tue, Apr 20, 2021 at 01:41:18PM +0200, Varad Gautam wrote:
>
> +static int psspad_set_sig_params(struct crypto_akcipher *tfm,
> + const void *sig,
> + unsigned int siglen)
> +{
> + struct akcipher_instance *inst = akcipher_alg_instance(tfm);
> + struct rsapad_inst_ctx *ictx = akcipher_instance_ctx(inst);
> + const struct public_key_signature *s = sig;
> +
> + if (!sig)
> + return -EINVAL;
> +
> + ictx->salt_len = s->salt_length;
> + ictx->mgf_hash_algo = s->mgf_hash_algo;

Is there any reason why this couldn't be embedded into the key
instead?

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt