Re: [PATCH] x86/acpi: Switch to pr_xxx log functions

From: Ingo Molnar
Date: Fri May 14 2021 - 06:20:33 EST



* Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:

> On Fri, May 14, 2021 at 9:07 AM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >
> >
> > * Heiner Kallweit <hkallweit1@xxxxxxxxx> wrote:
> >
> > > Switching to pr_debug et al has two benefits:
> > > - We don't have to add PREFIX to each log statement
> > > - Debug output is suppressed except DEBUG is defined or dynamic
> > > debugging is enabled for the respective code piece.
> > >
> > > In addition ensure that longer messages aren't split to multiple lines
> > > in source code, checkpatch complains otherwise.
> > >
> > > Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> > > ---
> > > arch/x86/kernel/acpi/boot.c | 118 ++++++++++++++----------------------
> > > 1 file changed, 47 insertions(+), 71 deletions(-)
> >
> > Reviewed-by: Ingo Molnar <mingo@xxxxxxxxxx>
>
> So I'm going to take this through the ACPI tree if that's OK.

Sure!

Thanks,

Ingo