Re: [PATCH net v7 0/3] fix packet stuck problem for lockless qdisc

[Jakub Kicinski]

On Thu, 13 May 2021 09:10:57 +0800 Yunsheng Lin wrote:
> This patchset fixes the packet stuck problem mentioned in [1].
> 
> Patch 1: Add STATE_MISSED flag to fix packet stuck problem.
> Patch 2: Fix a tx_action rescheduling problem after STATE_MISSED
>          flag is added in patch 1.
> Patch 3: Fix the significantly higher CPU consumption problem when
>          multiple threads are competing on a saturated outgoing
>          device.
> 
> V7: Fix netif_tx_wake_queue() data race noted by Jakub.
> V6: Some performance optimization in patch 1 suggested by Jakub
>     and drop NET_XMIT_DROP checking in patch 3.
> V5: add patch 3 to fix the problem reported by Michal Kubecek.
> V4: Change STATE_NEED_RESCHEDULE to STATE_MISSED and add patch 2.

Another review from someone who knows this code better would be great,
but it seems good to me (w/ minor nit on patch 3 addressed):

Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx>