Re: [PATCH v1 2/3] perf arm-spe: Correct sample flags for dummy event

From: Leo Yan
Date: Wed May 12 2021 - 13:31:04 EST


Hi James,

On Wed, May 12, 2021 at 06:17:03PM +0300, James Clark wrote:

[...]

> Apart from this issue above, I've tested the full patchset with various combinations
> of --per-thread, -a and --timestamp and don't see any issues like missing command names
> or decode issues. (Apart from -a where Command is reported as '-1', but this issue is
> present before and after this patchset so is unrelated.)

Good finding! Will take a look for the failure issue with option '-a'.

> I think it makes sense to unify the behaviour to make it more like Coresight and others
> so this is a good change.
>
> Reviewed-by: James Clark <james.clark@xxxxxxx>
> Tested-by: James Clark <james.clark@xxxxxxx>

Thanks a lot for the testing,

Leo