Re: [PATCH 3/8] serial: fsl_lpuart: don't restore interrupt state in ISR

[Michael Walle]

Am 2021-05-12 11:25, schrieb Johan Hovold:
> On Tue, May 11, 2021 at 10:01:43PM +0200, Michael Walle wrote:
> > Since commit 81e2073c175b ("genirq: Disable interrupts for force
> > threaded handlers") interrupt handlers that are not explicitly 
> > requested
> > as threaded are always called with interrupts disabled and there is no
> > need to save the interrupt state when taking the port lock.
>
> Since you've copied the above words verbatim from commit 75f4e830fa9c
> ("serial: do not restore interrupt state in sysrq helper") I'd expect
> you to use quotes or at least refer to the commit you copied the
> rationale from.

Sure, sorry.

> > This is a preparation for sysrq handling which uses
> > uart_unlock_and_check_sysrq();

-michael