RE: [PATCH v26 23/30] x86/cet/shstk: Handle thread shadow stack

[David Laight]

From: Borislav Petkov
> Sent: 11 May 2021 18:10
> 
> On Mon, May 10, 2021 at 03:57:56PM -0700, Yu, Yu-cheng wrote:
> > So this struct will be:
> >
> > struct thread_shstk {
> > 	u64 shstk_base;
> > 	u64 shstk_size;
> > 	u64 locked:1;
> > 	u64 ibt:1;

No point in bit fields?

> > };
> >
> > Ok?
> 
> Pretty much.
> 
> You can even remove the "shstk_" from the members and when you call the
> pointer "shstk", accessing the members will read
> 
> 	shstk->base
> 	shstk->size
> 	...
> 
> and all is organic and readable :)

And entirely not greppable.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)