Re: [PATCH -next] cpufreq: cppc: Remove unnecessary INIT_LIST_HEAD()

From: Viresh Kumar
Date: Wed May 12 2021 - 01:36:50 EST


On 11-05-21, 19:47, Yang Yingliang wrote:
> The list_head cpu_data_list is initialized statically.
> It is unnecessary to initialize by INIT_LIST_HEAD().
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 3848b4c222e1..b312fa210a39 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -723,8 +723,6 @@ static int __init cppc_cpufreq_init(void)
> if ((acpi_disabled) || !acpi_cpc_valid())
> return -ENODEV;
>
> - INIT_LIST_HEAD(&cpu_data_list);
> -
> cppc_check_hisi_workaround();
>
> ret = cpufreq_register_driver(&cppc_cpufreq_driver);

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh