Re: [PATCH rdma-next] RDMA/rdmavt: Decouple QP and SGE lists allocations

From: Dennis Dalessandro
Date: Wed May 12 2021 - 00:09:08 EST



On 5/11/21 3:27 PM, Leon Romanovsky wrote:
On Tue, May 11, 2021 at 07:15:09PM +0000, Marciniszyn, Mike wrote:

Why not kzalloc_node() here?

I agree here.

Other allocations that have been promoted to the core have lost the node attribute in the allocation.

Did you notice any performance degradation?


So what's the motivation to change it from the way it was originally designed? It seems to me if the original implementation went to the trouble to allocate the memory on the local node, refactoring the code should respect that.

-Denny